rabbah commented on a change in pull request #2218: Port Controller from Spray
to Akka
URL:
https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130366531
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -503,8 +503,9 @@ object Invoker {
})
val port = config.servicePort.toInt
+
BasicHttpService.startService(actorSystem, "invoker", "0.0.0.0", port,
new Creator[InvokerServer] {
- def create = new InvokerServer(invokerInstance,
config.invokerInstances.toInt)
+ def create = new InvokerServer(invokerInstance,
config.invokerInstances.toInt, port)
Review comment:
port passed twice (i know to different constructors) - would be nice to
avoid if doable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
