rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127038883
########## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ########## @@ -19,56 +19,64 @@ package whisk.http import scala.concurrent.duration.DurationInt import scala.language.postfixOps +import scala.concurrent.Await +import scala.collection.immutable.Seq +import scala.concurrent.ExecutionContext.Implicits.global Review comment: As a general rule neither the implicit context should be used or an explicit Await. @dubeejw can you scrub all occurrences that might have been introduced in the code (tests are different). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
