dubeejw commented on a change in pull request #2730: Reduce memory consumption
for action invocation
URL:
https://github.com/apache/incubator-openwhisk/pull/2730#discussion_r138198504
##########
File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
##########
@@ -126,6 +178,31 @@ protected[core] case class CodeExecAsAttachment(manifest:
RuntimeManifest,
}
}
+protected[core] case class CodeExecAsAttachment2(manifest: RuntimeManifest,
+ override val entryPoint:
Option[String])
+ extends CodeExec2[Attachment[String]] {
+ override val kind = manifest.kind
+ override val image = manifest.image
+ override val sentinelledLogs = manifest.sentinelledLogs.getOrElse(true)
+ override val deprecated = manifest.deprecated.getOrElse(false)
+ override val pull = false
+ override lazy val binary = true
+ override def codeAsJson = "".toJson //code.toJson
+
+ /*
Review comment:
TODO: delete commetted out code if not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
