dubeejw commented on a change in pull request #2730: Reduce memory consumption
for action invocation
URL:
https://github.com/apache/incubator-openwhisk/pull/2730#discussion_r138198831
##########
File path: core/controller/src/main/scala/whisk/core/controller/Actions.scala
##########
@@ -222,29 +222,49 @@ trait WhiskActionsApi extends WhiskCollectionAPI with
PostActionActivation with
*/
override def activate(user: Identity, entityName: FullyQualifiedEntityName,
env: Option[Parameters])(
implicit transid: TransactionId) = {
+
+ /*parameter('blocking ? false, 'result ? false,
'timeout.as[FiniteDuration] ? WhiskActionsApi.maxWaitForBlockingActivation) {
(blocking, result, waitOverride) =>
+ entity(as[Option[JsObject]]) { payload =>
+ getEntity(WhiskActionMini, entityStore, entityName.toDocId, Some {
action: WhiskActionMini =>
+ val mergedAction = env map {
+ action inherit _
+ } getOrElse action
+ complete(OK, mergedAction)
+ })
+ }
+ }*/
+
parameter(
'blocking ? false,
'result ? false,
'timeout.as[FiniteDuration] ?
WhiskActionsApi.maxWaitForBlockingActivation) { (blocking, result,
waitOverride) =>
entity(as[Option[JsObject]]) { payload =>
- getEntity(WhiskAction, entityStore, entityName.toDocId, Some {
- act: WhiskAction =>
+ logging.info(this, "here1")
+ getEntity(WhiskActionMini, entityStore, entityName.toDocId, Some {
+ act: WhiskActionMini =>
+ logging.info(this, "here2")
// resolve the action --- special case for sequences that may
contain components with '_' as default package
val action = act.resolve(user.namespace)
- onComplete(entitleReferencedEntities(user, Privilege.ACTIVATE,
Some(action.exec))) {
+ onComplete(entitleReferencedEntities2(user, Privilege.ACTIVATE,
Some(action.exec))) {
case Success(_) =>
+ logging.info(this, "here3")
Review comment:
TODO: remove extra logging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
