dubeejw commented on a change in pull request #2730: Reduce memory consumption
for action invocation
URL:
https://github.com/apache/incubator-openwhisk/pull/2730#discussion_r138198603
##########
File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
##########
@@ -144,12 +221,33 @@ protected[core] case class BlackBoxExec(override val
image: ImageName,
override def size = super.size + image.publicImageName.sizeInBytes
}
+protected[core] case class BlackBoxExec2(override val image: ImageName,
+ override val entryPoint:
Option[String],
+ val native: Boolean)
+ extends CodeExec2[Option[String]] {
+ override val kind = Exec2.BLACKBOX
+ override val deprecated = false
+ override def codeAsJson = "".toJson //code.toJson
+ override lazy val binary = false //TODO code map { Exec.isBinaryCode(_) }
getOrElse false
Review comment:
Can't determine binary type for actions with code property removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
