dgrove-oss commented on a change in pull request #2948: Programmatic lazy
creation of completedN and invokerN topics
URL:
https://github.com/apache/incubator-openwhisk/pull/2948#discussion_r150962187
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -182,6 +187,17 @@ object Invoker {
val invokerInstance = InstanceId(assignedInvokerId)
val msgProvider = SpiLoader.get[MessagingProvider]
+ if (!msgProvider.ensureTopic(
Review comment:
The general question is (which maybe has been answered and I just don't know
it), how are SPI implementations supposed to plumb their configuration values
from the deploying environment through to the implementation code that needs
them. Adding them all to WhiskConfig seems wrong, but I don't know what else
to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
