dgrove-oss commented on a change in pull request #2948: Programmatic lazy
creation of completedN and invokerN topics
URL:
https://github.com/apache/incubator-openwhisk/pull/2948#discussion_r151758420
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -182,6 +187,17 @@ object Invoker {
val invokerInstance = InstanceId(assignedInvokerId)
val msgProvider = SpiLoader.get[MessagingProvider]
+ if (!msgProvider.ensureTopic(
Review comment:
Once we have pureconfig and I can access the kafka-specific params internal
to the SPI implementation, I expect this block of code will reduce to
```
if (!msgProvider.ensureTopic(config, "invoker" + assignedInvokerId) {
abort(s"failure during msgProvider.ensureTopic for topic
invoker$assignedInvokerId")
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
