dgrove-oss commented on a change in pull request #2948: Programmatic lazy
creation of completedN and invokerN topics
URL:
https://github.com/apache/incubator-openwhisk/pull/2948#discussion_r151465127
##########
File path: ansible/roles/kafka/tasks/deploy.yml
##########
@@ -60,17 +60,3 @@
settings: "{{ kafka.topics.health }}"
Review comment:
I thought about that. Same for the cacheInvalidation topic. The
controllers could just race to create them on startup and one of them will win.
If we think it is a good idea, I can do a followup PR to get all the topic
logic out of ansible.
Should the followup PR wait on the pureconfig PR? If not, I'll have to
plumb more kafka-specific flags through the WhiskConfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
