sven-lange-last commented on a change in pull request #2878: Streamingly read
user-logs.
URL:
https://github.com/apache/incubator-openwhisk/pull/2878#discussion_r152023185
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##########
@@ -135,15 +142,14 @@ class DockerContainer(protected val id: ContainerId,
as: ActorSystem,
protected val ec:
ExecutionContext,
protected val logging:
Logging)
- extends Container
- with DockerActionLogDriver {
+ extends Container {
/** The last read-position in the log file */
- private var logFileOffset = 0L
+ private var logFileOffset = new AtomicLong(0)
Review comment:
Why do we need an `AtomicLong()` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
