sven-lange-last commented on a change in pull request #2878: Streamingly read
user-logs.
URL:
https://github.com/apache/incubator-openwhisk/pull/2878#discussion_r152944715
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
##########
@@ -369,10 +369,16 @@ class ContainerProxy(factory: (TransactionId, String,
ImageName, Boolean, ByteSi
}
.flatMap { activation =>
val start = tid.started(this, LoggingMarkers.INVOKER_COLLECT_LOGS)
- collectLogs(tid, container, job.action).map { logs =>
- tid.finished(this, start)
- activation.withLogs(logs)
- }
+ collectLogs(tid, container, job.action)
+ .map { logs =>
+ tid.finished(this, start)
+ activation.withLogs(logs)
+ }
+ .recover {
+ case _ =>
+ tid.failed(this, start)
+ activation.withLogs(ActivationLogs(Vector(Messages.logFailure)))
+ }
Review comment:
Thanks for adding the recovery path. If we end up in recovery: did we emit
the error to the invoker log anywhere after the error occurred? Otherwise we
have no change to understand what happened and don't even notice that
activation logs cannot be processed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
