sven-lange-last commented on a change in pull request #2878: Streamingly read
user-logs.
URL:
https://github.com/apache/incubator-openwhisk/pull/2878#discussion_r152240499
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala
##########
@@ -371,7 +368,9 @@ class ContainerProxy(factory: (TransactionId, String,
ImageName, Boolean, ByteSi
case Success(ack) => sendActiveAck(tid, ack, job.msg.blocking,
job.msg.rootControllerIndex)
}
.flatMap { activation =>
+ val start = tid.started(this, LoggingMarkers.INVOKER_COLLECT_LOGS)
collectLogs(tid, container, job.action).map { logs =>
+ tid.finished(this, start)
activation.withLogs(logs)
}
Review comment:
My understanding is that `collectLogs()` may return with a failed Future
such that the `INVOKER_COLLECT_LOGS` marker is never closed. As a convenience,
we should have a recovery path that adds a single log entry to the activation
that the log could not be obtained. Obviously, we don't do that today - but we
should do and unit test it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
