jonpspri commented on a change in pull request #3133: Subtle changes to support
S390X deployment of OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/pull/3133#discussion_r159543393
##########
File path: gradle/docker.gradle
##########
@@ -29,6 +44,7 @@ ext {
dockerRetries = project.hasProperty('dockerRetries') ?
dockerRetries.toInteger() : 3
dockerBinary = project.hasProperty('dockerBinary') ? [dockerBinary] :
['docker']
dockerBuildArg = ['build']
+ dockerArch = project.hasProperty('dockerArch') ? dockerArch :
detectDockerArch()
Review comment:
Hmm... I see your point, but it opens a big can of worms about where the
build is running vs where the target machine is. This worked great for logging
onto the LoZ environment and typing './gradlew distDocker' before running the
ansible local configuration. The detect is useful because it ensure the
architecture of the Dockerfile matches to where the build will be run. The
gradle script doesn't really have any insight into target architecture, and
passing it a dockerArch that mis-matches the Docker it's running on will have
core-generating results.
I can take it or leave it -- removing it just adds one more parameter to
remember to get right when running './gradlew'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
