jonpspri commented on a change in pull request #3133: Subtle changes to support
S390X deployment of OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/pull/3133#discussion_r159543393
##########
File path: gradle/docker.gradle
##########
@@ -29,6 +44,7 @@ ext {
dockerRetries = project.hasProperty('dockerRetries') ?
dockerRetries.toInteger() : 3
dockerBinary = project.hasProperty('dockerBinary') ? [dockerBinary] :
['docker']
dockerBuildArg = ['build']
+ dockerArch = project.hasProperty('dockerArch') ? dockerArch :
detectDockerArch()
Review comment:
Hmm... I see your concern, but I would contend that the architecture of the
target build docker (not build machine) IS the build architecture because it
doesn't make sense to try to create any different images than that target. In
other words, running an 'x86' Dockerfile on an 's390x' docker is going to fail
or create an unusable image (assuming they're different _a la_ scala). That's
why the detection seems the best way to go with manually specifying the
architecture being an override more prone to human error.
The detect will, for example, notice that I'm building on an s390x docker if
I've connected remotely from my mac.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
