jonpspri commented on a change in pull request #3133: Subtle changes to support
S390X deployment of OpenWhisk
URL:
https://github.com/apache/incubator-openwhisk/pull/3133#discussion_r159543785
##########
File path: gradle/docker.gradle
##########
@@ -42,14 +58,42 @@ if(project.hasProperty('dockerBuildArgs')) {
}
}
+task templateDockerfile (type: Copy) {
+ def directory = project.buildscript.sourceFile.getParentFile()
+ from directory
+ into directory
+ include 'Dockerfile.in'
Review comment:
There are two options for Dockerfile. 'Dockerfile.s390x' if it exists will
completely override 'Dockerfile'. Option 2 is 'Dockerfile.in' would be run
through the groovy template engine. It's intended for small differences in the
Dockerfile (e.g. Debian releases). I'm not sure Option 2 is even in use here,
and so perhaps I should just rip it out for the sake of readability/clarity. I
had left it in in case it was needed later. At any rate, I need better comment
documentation apparently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
