tysonnorris commented on a change in pull request #2984: Dynamic LoadBalancer
load using SpiLoader
URL:
https://github.com/apache/incubator-openwhisk/pull/2984#discussion_r161110567
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -84,15 +89,23 @@ trait LoadBalancer {
def publish(action: ExecutableWhiskActionMetaData, msg: ActivationMessage)(
implicit transid: TransactionId): Future[Future[Either[ActivationId,
WhiskActivation]]]
+ /**
Review comment:
^^^ (line 72) as discussed a while back in #2668, it may be worthwhile
changing the LoadBalancer trait to have a generic "check()" function, which may
do things other than a systemwide and per-namespace activation check. This
requires some changes in RateThrottler etc.
I'd be OK waiting on this till later, but it will require changing the
interface exposed by the SPI later - I'm not sure whether that is sooner vs
later. WDYT @rabbah ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
