tysonnorris commented on a change in pull request #2984: Dynamic LoadBalancer
load using SpiLoader
URL:
https://github.com/apache/incubator-openwhisk/pull/2984#discussion_r161111038
##########
File path: common/scala/src/main/resources/reference.conf
##########
@@ -3,4 +3,5 @@ whisk.spi{
MessagingProvider = whisk.connector.kafka.KafkaMessagingProvider
ContainerFactoryProvider =
whisk.core.containerpool.docker.DockerContainerFactoryProvider
LogStoreProvider =
whisk.core.containerpool.logging.DockerToActivationLogStoreProvider
+ LoadBalancerProvider = whisk.core.loadBalancer.LoadBalancerService
Review comment:
I don't have a strong opinion, but it may be good to have more specific
names to the Spi impl, e.g.
`whisk.core.loadBalancer.DefaultLoadBalancerProvider` (not sure of a great name
here; maybe `KafkaLoadBalancerProvider`?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
