tysonnorris commented on a change in pull request #2984: Dynamic LoadBalancer
load using SpiLoader
URL:
https://github.com/apache/incubator-openwhisk/pull/2984#discussion_r162212750
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -84,15 +89,23 @@ trait LoadBalancer {
def publish(action: ExecutableWhiskActionMetaData, msg: ActivationMessage)(
implicit transid: TransactionId): Future[Future[Either[ActivationId,
WhiskActivation]]]
+ /**
Review comment:
I don't think this would impact the overflow q, since the throttling is done
upstream, it is just a way to make the throttling implementation specific to a
loadbalancer, and possibly more comprehensive than what exists today (action
specific limits, dynamic limits, etc).
We can revisit that later as long as its ok to rev the interface (which I am
ok with as well)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
