rabbah commented on a change in pull request #3174: Change log level 
dynamically (updated)
URL: 
https://github.com/apache/incubator-openwhisk/pull/3174#discussion_r161557857
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/Logging.scala
 ##########
 @@ -37,7 +37,11 @@ trait Logging {
    * @param message Message to write to the log
    */
   def debug(from: AnyRef, message: String)(implicit id: TransactionId = 
TransactionId.unknown) = {
-    emit(DebugLevel, id, from, message)
+    if (id.meta.extraLogging) {
 
 Review comment:
   should this be applied to _all_ the logger methods not just debug perhaps by 
making the change in the `emit` method instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to