rabbah commented on a change in pull request #3174: Change log level 
dynamically (updated)
URL: 
https://github.com/apache/incubator-openwhisk/pull/3174#discussion_r161558545
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala
 ##########
 @@ -90,7 +91,13 @@ trait BasicHttpService extends Directives with 
TransactionCounter {
   }
 
   /** Assigns transaction id to every request. */
-  protected val assignId = extract(_ => transid())
+  protected def assignId = 
HeaderDirectives.optionalHeaderValueByName(OW_EXTRA_LOGGING_HEADER) flatMap { 
headerValue =>
 
 Review comment:
   add a comment? e.g. `extract headers from HTTP request that indicates if 
additional logging should be enabled for this transaction. Allowed values are 
...`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to