rabbah commented on a change in pull request #3174: Change log level
dynamically (updated)
URL:
https://github.com/apache/incubator-openwhisk/pull/3174#discussion_r161558306
##########
File path: common/scala/src/main/scala/whisk/common/TransactionId.scala
##########
@@ -221,21 +217,29 @@ object TransactionId {
val controller = TransactionId(-130) // Controller startup
val dbBatcher = TransactionId(-140) // Database batcher
- def apply(tid: BigDecimal): TransactionId = {
+ def apply(tid: BigDecimal, extraLogging: Boolean = false): TransactionId = {
Try {
val now = Instant.now(Clock.systemUTC())
- TransactionId(TransactionMetadata(tid.toLong, now))
+ TransactionId(TransactionMetadata(tid.toLong, now, extraLogging))
} getOrElse unknown
}
implicit val serdes = new RootJsonFormat[TransactionId] {
- def write(t: TransactionId) = JsArray(JsNumber(t.meta.id),
JsNumber(t.meta.start.toEpochMilli))
+ def write(t: TransactionId) = {
Review comment:
could you add a test (SchemaTests perhaps) to confirm the intended behavior
for the serdes in the presence/absence of the additional field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
