tysonnorris commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility URL: https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193895111
########## File path: common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala ########## @@ -53,10 +58,12 @@ import whisk.core.entity.size.SizeLong * @param hostname the host name * @param timeout the timeout in msecs to wait for a response * @param maxResponse the maximum size in bytes the connection will accept + * @param maxConcurrent the maximum number of concurrent requests allowed */ -protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxResponse: ByteSize)( +protected[core] class HttpUtils(hostname: String, timeout: FiniteDuration, maxResponse: ByteSize, maxConcurrent: Int)( Review comment: Tried this, it fails compilation with an issue in using `object HttpUtils` from elsewhere - doesn't seem right, is there something special when object is public, using private class with default constructor args? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
