tysonnorris commented on a change in pull request #3707: enable concurrent runs
on ActionContainer test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193897689
##########
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##########
@@ -65,13 +67,26 @@ trait ActionProxyContainerTestUtils extends FlatSpec with
Matchers with StreamLo
def checkStreams(out: String,
err: String,
additionalCheck: (String, String) => Unit,
- sentinelCount: Int = 1): Unit = {
+ sentinelCount: Int = 1,
+ concurrent: Boolean = false): Unit = {
withClue("expected number of stdout sentinels") {
sentinelCount shouldBe StringUtils.countMatches(out, sentinel)
}
+ //sentinels should be all together
+ if (concurrent) {
Review comment:
The sentinels of different activations will be interleaved, but only with
sentinels of other activations, not with log messages. It is true this assumes
that the activations processing concurrently are run with this test class, and
it is also true that an image could have behavior to cause concurrently
submitted activations to emit sentinels at different times. I'll see if
something better can be done, but I'm not sure what - we need to make sure the
log output is interleaved amongst concurrent activations, but predicting the
exact should be impossible, unless the action forces ordering within, defeating
the concurrency model...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
