tysonnorris commented on a change in pull request #3707: enable concurrent runs
on ActionContainer test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r193920614
##########
File path: tests/src/test/scala/actionContainers/ActionContainer.scala
##########
@@ -65,13 +67,26 @@ trait ActionProxyContainerTestUtils extends FlatSpec with
Matchers with StreamLo
def checkStreams(out: String,
err: String,
additionalCheck: (String, String) => Unit,
- sentinelCount: Int = 1): Unit = {
+ sentinelCount: Int = 1,
+ concurrent: Boolean = false): Unit = {
withClue("expected number of stdout sentinels") {
sentinelCount shouldBe StringUtils.countMatches(out, sentinel)
}
+ //sentinels should be all together
+ if (concurrent) {
Review comment:
That is done already, but what is important is the unknown ordering of
sentinels vs log output since these should be different when container runs
activations concurrently (without concurrency, the container logs always
alternate between <log><sentinel><log><sentinel>...). With concurrent
activations, the sentinel from previous activation may output in between logs
of subsequent activations, like:
```
<activation1 log>
<activation1 log>
<activation2 log>
<activation1 sentinel>
<activation2 log>
<activation2 sentinel>
```
So in the nodejs container test I will force the activation logs to all be
output before any sentinels are output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
