markusthoemmes commented on a change in pull request #3812: ContainerClient +
akka http alternative to HttpUtils
URL:
https://github.com/apache/incubator-openwhisk/pull/3812#discussion_r203882516
##########
File path: common/scala/src/main/scala/whisk/core/containerpool/Container.scala
##########
@@ -166,16 +170,20 @@ trait Container {
implicit transid: TransactionId): Future[RunResult] = {
val started = Instant.now()
val http = httpConnection.getOrElse {
- val conn = new HttpUtils(s"${addr.host}:${addr.port}", timeout, 1.MB)
+ val conn = if (config.poolingClient) {
Review comment:
`poolingClient` seems an odd name since `HttpUtils` does pool as well.
Should we rename to `newContainerClient`? (akka themselves did the same when
they implemented the new ConnectionPool)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
