markusthoemmes commented on a change in pull request #3812: ContainerClient +
akka http alternative to HttpUtils
URL:
https://github.com/apache/incubator-openwhisk/pull/3812#discussion_r203981897
##########
File path:
tests/src/test/scala/whisk/core/containerpool/kubernetes/test/KubernetesClientTests.scala
##########
@@ -188,6 +189,7 @@ object KubernetesClientTests {
implicit def strToInstant(str: String): Instant =
strToDate(str).get
+ implicit val as = ActorSystem("kubernetes-client-tests-actor-system")
Review comment:
This actorSystem is leaked I think. Could you make the
`TestKubernetesClient` take the actorSystem as an implicit parameter, so you
can use the one imported (and closed) by the tests above?
Or maybe even move the class into the testclass. Makes it even easier?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
