markusthoemmes commented on a change in pull request #3812: ContainerClient +
akka http alternative to HttpUtils
URL:
https://github.com/apache/incubator-openwhisk/pull/3812#discussion_r203981358
##########
File path:
tests/src/test/scala/whisk/core/containerpool/test/ContainerPoolTests.scala
##########
@@ -296,7 +301,7 @@ class ContainerPoolTests
val (containers, factory) = testContainers(2)
val feed = TestProbe()
- val pool = system.actorOf(ContainerPool.props(factory,
ContainerPoolConfig(2, 2), feed.ref))
+ val pool = system.actorOf(ContainerPool.props(factory,
ContainerPoolConfig(2, 2, false), feed.ref))
Review comment:
I think we should externalize building of the ContainerPoolConfig into a
method so we don't need to adjust the values not needed for these tests
continually. Check
https://github.com/apache/incubator-openwhisk/pull/3767/files#diff-d00e1ef9ea3255332a28c35676361e29
for an impl. I did in another PR of exactly the same issue. I think it keeps
the testcases clearer and reduces the diff in future PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
