markusthoemmes commented on a change in pull request #3812: ContainerClient +
akka http alternative to HttpUtils
URL:
https://github.com/apache/incubator-openwhisk/pull/3812#discussion_r203980538
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##########
@@ -190,29 +190,33 @@ class DockerContainer(protected val id: ContainerId,
implicit transid: TransactionId): Future[RunResult] = {
val started = Instant.now()
val http = httpConnection.getOrElse {
- val conn = new HttpUtils(s"${addr.host}:${addr.port}", timeout,
ActivationEntityLimit.MAX_ACTIVATION_ENTITY_LIMIT)
+ val conn = new ApacheBlockingContainerClient(
+ s"${addr.host}:${addr.port}",
+ timeout,
+ ActivationEntityLimit.MAX_ACTIVATION_ENTITY_LIMIT)
Review comment:
Shouldn't this also check the feature toggle and use the correct client as
configured?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services