tysonnorris commented on a change in pull request #4186: Track activation 
counts in ContainerPool (not ContainerProxy)
URL: 
https://github.com/apache/incubator-openwhisk/pull/4186#discussion_r250068095
 
 

 ##########
 File path: 
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -140,15 +150,50 @@ class ContainerPool(childFactory: ActorRefFactory => 
ActorRef,
 
         createdContainer match {
           case Some(((actor, data), containerState)) =>
+            //increment active count before storing in pool map
+            val (newData, container) = data match {
+              case p: PreWarmedData => //convert PreWarmedData -> WarmingData 
for concurrent cases
 
 Review comment:
   Sounds good - added a `def scheduleUsage(r: Run): ContainerData` to 
`ContainerData`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to