tysonnorris commented on a change in pull request #4186: Track activation
counts in ContainerPool (not ContainerProxy)
URL:
https://github.com/apache/incubator-openwhisk/pull/4186#discussion_r252815291
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##########
@@ -88,7 +88,7 @@ class ContainerPool(childFactory: ActorRefFactory =>
ActorRef,
r.msg.transid.mark(
this,
LoggingMarkers.INVOKER_CONTAINER_START(containerState),
- s"containerStart containerState: $containerState ($activeActivations of
max $maxConcurrent) action: $actionName namespace: $namespaceName activationId:
$activationId",
+ s"containerStart containerState: $containerState container: $container
activations: $activeActivations of max $maxConcurrent action: $actionName
namespace: $namespaceName activationId: $activationId",
Review comment:
Not easily, because the state is not unique to the container data instance
type - the state tracking is a little weird with `recreatedPrewarm` and
`recreated`, which are variants of `prewarmed` and `cold`. Ideas welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
