tysonnorris commented on a change in pull request #4186: Track activation
counts in ContainerPool (not ContainerProxy)
URL:
https://github.com/apache/incubator-openwhisk/pull/4186#discussion_r252816124
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##########
@@ -342,12 +380,35 @@ object ContainerPool {
protected[containerpool] def schedule[A](action: ExecutableWhiskAction,
invocationNamespace: EntityName,
idles: Map[A, ContainerData]):
Option[(A, ContainerData)] = {
- idles.find {
- case (_, WarmedData(_, `invocationNamespace`, `action`, _,
activeActivationCount))
- if activeActivationCount < action.limits.concurrency.maxConcurrent =>
- true
- case _ => false
- }
+ idles
Review comment:
The `ContainerData` types have docs now:
https://github.com/apache/incubator-openwhisk/pull/4186/files#diff-170ae706abad4ff6500ae12be05d0cbbR131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
