falkzoll commented on a change in pull request #4450: Fix test cases to also
work with nodejs:10 as default nodejs runtime.
URL:
https://github.com/apache/incubator-openwhisk/pull/4450#discussion_r276241007
##########
File path: tests/src/test/scala/invokerShoot/ShootInvokerTests.scala
##########
@@ -172,6 +172,7 @@ class ShootInvokerTests extends TestHelpers with
WskTestHelpers with JsHelpers w
it should "add new parameters and annotations while copying an action" in
withAssetCleaner(wskprops) {
(wp, assetHelper) =>
+ val runtime = "nodejs:10"
Review comment:
Right, that would be the best 👍.
Unfortunately many tests explicitly check the returned runtime string, e.g.
for 'nodejs:6'. When we use 'nodejs:default' at action creation, this returned
runtime string would be whatever the actual default runtime is.
In this case we would need to either query somehow in the test case what the
current default runtime is, which we then can use to compare in the test case.
Or, we could check against a list of possible nodejs runtimes (nodejs:6,
nodejs:8, nodejs:10). But then we would also need to adjust this list when we
add newer versions.
Or, the other option would be, we do not compare the returned runtime string
at all. Which would be the easiest solution,
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
