falkzoll commented on a change in pull request #4450: Fix test cases to also 
work with nodejs:10 as default nodejs runtime.
URL: 
https://github.com/apache/incubator-openwhisk/pull/4450#discussion_r277528481
 
 

 ##########
 File path: tests/src/test/scala/invokerShoot/ShootInvokerTests.scala
 ##########
 @@ -172,6 +172,7 @@ class ShootInvokerTests extends TestHelpers with 
WskTestHelpers with JsHelpers w
 
   it should "add new parameters and annotations while copying an action" in 
withAssetCleaner(wskprops) {
     (wp, assetHelper) =>
+      val runtime = "nodejs:10"
 
 Review comment:
   yes, makes sense, I will look for a generic check like `nodejs:*` and see if 
we can modify the tests accordingly … the travis 'System Tests' also still show 
a failure I need to analyse and fix… I will get back to you when I am done with 
that :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to