falkzoll commented on a change in pull request #4450: Fix test cases to also
work with nodejs:10 as default nodejs runtime.
URL:
https://github.com/apache/incubator-openwhisk/pull/4450#discussion_r277965881
##########
File path: tests/dat/actions/openFiles.js
##########
@@ -22,7 +22,7 @@ function main(params) {
console.log("opened files = ", openFiles.length);
openFiles.forEach(function(fh) {
- fs.close(fh);
+ fs.close(fh, (err) => {} );
Review comment:
The empty callback was added since this parameter was optional for nodejs:6
but is now required for nodejs:10. Using an empty callback funtion sounded to
be the default behaviour when this parameter is not present in nodejs:6.
Explicitly defining the empty callback now, works with both nodejs:6 and
nodejs:10.
You are right, making this a `closeSync ` call will most likely not change
the test behaviour, since this is cleanup code at the end of the test. But I
would need to try it first with both node versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
