[
https://issues.apache.org/jira/browse/ORC-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994002#comment-15994002
]
ASF GitHub Bot commented on ORC-185:
------------------------------------
Github user wgtmac commented on the issue:
https://github.com/apache/orc/pull/116
Overall the PIMPL looks nicer than the current implementation. My main
concern for using templates is that we need to compare & update values of
different types, merge ColumnStatistics, and transform to protobuf version for
implementing writers and using templates may not help in this case. It means we
still need to do template specialization for different types like Date,
Timestamp, Decimal, etc. if we want to let class ColumnStatistics to handle the
update (e.g. use ColumnStatistics<T>::update(T value) to update min/max for
type T). Otherwise we may need to let specific ColumnWriters to be responsible
for update (e.g. DecimalColumnWriter to compare min/max of decimal values and
then use setMax/setMin of ColumnStatistics<Decimal> to update the values).
> [C++] Simplify Statististics Implementation
> -------------------------------------------
>
> Key: ORC-185
> URL: https://issues.apache.org/jira/browse/ORC-185
> Project: ORC
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> There is a lot of code duplication in the current ColumnStatistics
> implementation. The scope of this JIRA is to use templates to reuse code as
> much as possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
