[
https://issues.apache.org/jira/browse/ORC-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994179#comment-15994179
]
ASF GitHub Bot commented on ORC-185:
------------------------------------
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/116
You have to specialize the code for non-primitive types. There is no other
option. I would say specialization of methods like `compare, update` inside
`InternalStatisticsImpl` is the right and simple way to go forward. This class
should be responsible for handling the statistics updates.
ColumnWriters will just have an instance of the InternalStatisticsImpl and
call the corresponding methods to `update` on writing a new value.
> [C++] Simplify Statististics Implementation
> -------------------------------------------
>
> Key: ORC-185
> URL: https://issues.apache.org/jira/browse/ORC-185
> Project: ORC
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> There is a lot of code duplication in the current ColumnStatistics
> implementation. The scope of this JIRA is to use templates to reuse code as
> much as possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
