[
https://issues.apache.org/jira/browse/ORC-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995198#comment-15995198
]
ASF GitHub Bot commented on ORC-185:
------------------------------------
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/116#discussion_r114596159
--- Diff: c++/src/Statistics.hh ---
@@ -64,103 +64,63 @@ namespace orc {
hasMaximum_ = false;
hasSum_ = false;
hasTotalLength_ = false;
- totalLength_ = -1;
- valueCount_ = -1;
+ totalLength_ = 0;
+ valueCount_ = 0;
}
~InternalStatisticsImpl() {}
// GET / SET totalLength_
- bool hasTotalLength() const {
- return hasTotalLength_;
- }
+ bool hasTotalLength() const {return hasTotalLength_;}
--- End diff --
Spaces need to be used here to separate braces from implementation.
[Horizontal_Whitespace](https://google.github.io/styleguide/cppguide.html#Horizontal_Whitespace)
> [C++] Simplify Statististics Implementation
> -------------------------------------------
>
> Key: ORC-185
> URL: https://issues.apache.org/jira/browse/ORC-185
> Project: ORC
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> There is a lot of code duplication in the current ColumnStatistics
> implementation. The scope of this JIRA is to use templates to reuse code as
> much as possible.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
