[
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194055#comment-16194055
]
Sergey Shelukhin commented on ORC-243:
--------------------------------------
I'm not suggesting we move the requirement, I'm suggesting we remove it. The
same way, speaking purely about contracts and APIs, having the object passed in
for reuse, instead of allocated on demand, is not a clean contract, but is
required for perf. Being able to reuse a valid object instead of requiring it
to be in a very particular state is another such change that is completely
reasonable; esp. since most/all nextVector calls don't rely on this particular
state and set up the vector from scratch, so it's wasted work.
This still doesn't address (2).
Also it became public API when we didn't take LLAP ORC readers into ORC project
when splitting. There should be guidelines for implementing custom ORC
readers... either they can reuse parts of ORC via such APIs, or they'd need a
fork :P
> incorrect isRepeating handling in decimal reader
> ------------------------------------------------
>
> Key: ORC-243
> URL: https://issues.apache.org/jira/browse/ORC-243
> Project: ORC
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Blocker
> Attachments: ORC-243.patch
>
>
> This can lead to incorrect results.
> I need to look at other readers, will do tomorrow if this looks ok in general.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
