[ 
https://issues.apache.org/jira/browse/ORC-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195016#comment-16195016
 ] 

Sergey Shelukhin commented on ORC-243:
--------------------------------------

Actually, TreeReader-s need to create valid vectors, so they do need to know 
about every flag - either explicitly, or by unobvious assumptions, as 
illustrated by (2). Nothing needs to be reset.
Yeah, the usage of correct vectors implies not looking at isNull when noNulls 
is set which is acceptable... we won't need noNulls flag if we were checking 
isNulls every time ;)

> incorrect isRepeating handling in decimal reader
> ------------------------------------------------
>
>                 Key: ORC-243
>                 URL: https://issues.apache.org/jira/browse/ORC-243
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Blocker
>         Attachments: ORC-243.patch
>
>
> This can lead to incorrect results. 
> I need to look at other readers, will do tomorrow if this looks ok in general.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to