coderex2522 commented on code in PR #1158:
URL: https://github.com/apache/orc/pull/1158#discussion_r903653302
##########
c++/include/orc/OrcFile.hh:
##########
@@ -105,20 +105,26 @@ namespace orc {
/**
* Create a stream to a local file or HDFS file if path begins with "hdfs://"
* @param path the name of the file in the local file system or HDFS
+ * @param metrics the metrics of the reader
*/
- ORC_UNIQUE_PTR<InputStream> readFile(const std::string& path);
+ ORC_UNIQUE_PTR<InputStream> readFile(const std::string& path,
+ ReaderMetrics& metrics);
Review Comment:
Parameter references for the metrics do cause compatibility issues. I
replaced the all parameter reference with metrics pointer. And use macro
DEFINE_AUTO_STOPWATCH to do the metrics pointer null checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
