dongjoon-hyun commented on code in PR #1158:
URL: https://github.com/apache/orc/pull/1158#discussion_r916029792


##########
c++/include/orc/Reader.hh:
##########
@@ -76,6 +99,11 @@ namespace orc {
      */
     ReaderOptions& setMemoryPool(MemoryPool& pool);
 
+    /**
+     * Set the reader metrics.

Review Comment:
   Could you add a description where `setReaderMetrics(nullptr)`? I guess, it 
could be used to disable ReaderMetrics?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to