dongjoon-hyun commented on code in PR #1158:
URL: https://github.com/apache/orc/pull/1158#discussion_r916027886
##########
c++/src/Compression.hh:
##########
@@ -30,12 +30,14 @@ namespace orc {
* @param input the input stream that is the underlying source
* @param bufferSize the maximum size of the buffer
* @param pool the memory pool
+ * @param metrics the reader metrics
*/
std::unique_ptr<SeekableInputStream>
createDecompressor(CompressionKind kind,
std::unique_ptr<SeekableInputStream> input,
uint64_t bufferSize,
- MemoryPool& pool);
+ MemoryPool& pool,
+ ReaderMetrics* metrics);
Review Comment:
If you don't mind, shall we have the default value, `ReaderMetrics* metrics
= nullptr`, to be more backward-compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
