pavibhai commented on code in PR #1482:
URL: https://github.com/apache/orc/pull/1482#discussion_r1183569817
##########
java/core/src/test/org/apache/orc/TestOrcFilterContext.java:
##########
@@ -225,4 +230,12 @@ public void testRepeatingVector() {
assertTrue(OrcFilterContext.isNull(vectorBranch, 1));
assertTrue(OrcFilterContext.isNull(vectorBranch, 2));
}
+
+ @Test
+ public void testACIDTable(){
Review Comment:
You can take a look at
[TestRowFilteringIOSkip](https://github.com/apache/orc/blob/main/java/core/src/test/org/apache/orc/TestRowFilteringIOSkip.java).
I am not sure what the contract wit hive is in this case, but will be good
to have the following scenarios:
* File written with ACID schema and read with ACID schema with filter
* File written with ACID schema and read without ACID schema with filter
* File written with no ACID schema and read with ACID schema with filter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
