pavibhai commented on code in PR #1482:
URL: https://github.com/apache/orc/pull/1482#discussion_r1189234542
##########
java/core/src/java/org/apache/orc/impl/ParserUtils.java:
##########
@@ -281,7 +282,7 @@ public void visit(TypeDescription type, int posn) {
public static TypeDescription findSubtype(TypeDescription schema,
ParserUtils.StringPosition source,
boolean
isSchemaEvolutionCaseAware) {
- TypeFinder result = new TypeFinder(removeAcid(schema));
+ TypeFinder result = new TypeFinder(schema);
Review Comment:
I am uncomfortable changing this here. This method is being used in multiple
places and we need to ensure in all the places the source includes the prefix
of `row`.
These are the following two broad approaches I see here.
1. Ignore the`row` `StructColumnVector` in all processing, which seems to be
case with the current code when removing acid schema.
2. Consider the `row` column vector in all of the processing (partially
implemented)
I am leaning towards the first option so as not to change the behavior of
the APIs. e.g. if previously one was calling with col1, now they are expected
to call as row.col1 which is a change in behavior.
This is also feels like it will minimize the amount of code that needs to be
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
