pavibhai commented on code in PR #1482:
URL: https://github.com/apache/orc/pull/1482#discussion_r1189235669
##########
java/core/src/java/org/apache/orc/impl/ParserUtils.java:
##########
@@ -459,8 +466,8 @@ public static ColumnVector[]
findColumnVectors(TypeDescription schema,
boolean isCaseSensitive,
VectorizedRowBatch batch) {
List<String> names = ParserUtils.splitName(source);
- ColumnFinder result = new ColumnFinder(schema, batch, names.size());
Review Comment:
It feels like it would be sufficient to add a new constructor to
ColumnFinder that can also take an array of column vectors that in case the
case of acid schema is the column vectors from the `row` column vector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
