XinyuZeng commented on code in PR #1739:
URL: https://github.com/apache/orc/pull/1739#discussion_r1447221145
##########
c++/src/MemoryPool.cc:
##########
@@ -57,6 +57,15 @@ namespace orc {
resize(newSize);
}
+ // This constructor is used to create a DataBuffer that does not need to be
memset to 0.
+ // bool noMemSet is not used in the code, but is kept here to avoid run-time
branching.
+ template <class T>
+ DataBuffer<T>::DataBuffer(MemoryPool& pool, uint64_t newSize,
[[maybe_unused]] bool noMemSet)
Review Comment:
I feel the current way to differentiate the two constructors is ugly. Feel
free to propose better one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
