XinyuZeng commented on code in PR #1739:
URL: https://github.com/apache/orc/pull/1739#discussion_r1451347974
##########
c++/src/MemoryPool.cc:
##########
@@ -57,6 +57,15 @@ namespace orc {
resize(newSize);
}
+ // This constructor is used to create a DataBuffer that does not need to be
memset to 0.
+ // memset_tag is not used in the code, but is kept here to avoid run-time
branching.
+ template <class T>
+ DataBuffer<T>::DataBuffer(MemoryPool& pool, uint64_t newSize,
no_memset_tag_t)
Review Comment:
The new commit changes to this way. It can pass test. But I did not check
the logic of every place where DataBuffer is constructed to ensure they do not
implicitly assume the buffer is set to zero. The only place I found so far is
`MapColumnWriter::add`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
