XinyuZeng commented on code in PR #1739:
URL: https://github.com/apache/orc/pull/1739#discussion_r1447286853
##########
c++/include/orc/MemoryPool.hh:
##########
@@ -51,6 +51,7 @@ namespace orc {
public:
DataBuffer(MemoryPool& pool, uint64_t _size = 0);
+ DataBuffer(MemoryPool& pool, uint64_t _size, bool noMemSet);
Review Comment:
Never use. The problem is that it is not possible to provide explicit
`template <bool noMemSet>` to a constructor. Perhaps we can allow this branch
in constructor? That makes the code better but introduce a branch that should
be resolved at compile time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
