wgtmac commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1569814941
##########
c++/src/CMakeLists.txt:
##########
@@ -202,18 +202,29 @@ endif(BUILD_ENABLE_AVX512)
add_library (orc STATIC ${SOURCE_FILES})
target_link_libraries (orc
- orc::protobuf
- orc::zlib
- orc::snappy
- orc::lz4
- orc::zstd
- ${LIBHDFSPP_LIBRARIES}
+ INTERFACE
+ $<INSTALL_INTERFACE:protobuf::libprotobuf>
Review Comment:
It seems that downstream clients are required to add
```
find_package(Protobuf REQUIRED)
find_package(ZLIB REQUIRED)
find_package(Snappy REQUIRED)
```
before the line
```
find_package(orc REQUIRED CONFIG)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
