wgtmac commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1569856376
##########
c++/src/CMakeLists.txt:
##########
@@ -202,18 +202,29 @@ endif(BUILD_ENABLE_AVX512)
add_library (orc STATIC ${SOURCE_FILES})
target_link_libraries (orc
- orc::protobuf
- orc::zlib
- orc::snappy
- orc::lz4
- orc::zstd
- ${LIBHDFSPP_LIBRARIES}
+ INTERFACE
+ $<INSTALL_INTERFACE:protobuf::libprotobuf>
+ $<INSTALL_INTERFACE:ZLIB::ZLIB>
+ $<INSTALL_INTERFACE:Snappy::snappy>
+ $<INSTALL_INTERFACE:$<TARGET_NAME_IF_EXISTS:LZ4::lz4_static>>
Review Comment:
Adding `TARGET_NAME_IF_EXISTS` generator expression looks like a bad idea as
it does not complain a missing call to find_package any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
