kou commented on code in PR #1889:
URL: https://github.com/apache/orc/pull/1889#discussion_r1574421813
##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -132,6 +154,9 @@ else ()
BUILD_BYPRODUCTS "${SNAPPY_STATIC_LIB}")
add_built_library (snappy_ep orc_snappy ${SNAPPY_STATIC_LIB}
${SNAPPY_INCLUDE_DIR})
+
+ list (APPEND ORC_VENDOR_DEPENDENCIES
"vendored_snappy:${SNAPPY_STATIC_LIB_NAME}")
+ list (APPEND ORC_INSTALL_INTERFACE_TARGETS
"$<INSTALL_INTERFACE:vendored_snappy>")
Review Comment:
How about putting this target to `orc::` namespace for safety?
```suggestion
list (APPEND ORC_VENDOR_DEPENDENCIES
"orc::vendored_snappy:${SNAPPY_STATIC_LIB_NAME}")
list (APPEND ORC_INSTALL_INTERFACE_TARGETS
"$<INSTALL_INTERFACE:orc::vendored_snappy>")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
